Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Renames js files into "proper" jsx #770

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25176
Original PR: tgstation/tgstation#79877

About The Pull Request

A quirk of vite is that it prefers jsx-returning javascript files to be aptly named *.jsx

Where it was free, I switched the file to .ts. Notably, there are no constants.js anymore (huzzah for tab completion)

Why It's Good For The Game

Smooth upgrade?

Changelog

N/A nothing player facing

* Renames js files into "proper" jsx

* Rename skyrat js

---------

Co-authored-by: Jeremiah <[email protected]>
Co-authored-by: Giz <[email protected]>
@Iajret Iajret merged commit e35ead0 into master Nov 22, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25176 branch November 22, 2023 22:57
Iajret pushed a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants